Change in ovirt-engine[ovirt-engine-4.0]: utils: Encapsulte OVF build algo into OvfBuilder

Code Review gerrit at ovirt.org
Wed Nov 9 12:55:14 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: utils: Encapsulte OVF build algo into OvfBuilder
......................................................................


utils: Encapsulte OVF build algo into OvfBuilder

The steps to build the OVF where called outside by the OvfManager. Its
the responsiblity of the Object to build its internal structure and so
it is encapsulated into it, making the API safer, easier and cleaner.

Change-Id: I427aa4e9ada86c59e4d7cf999dbdb23aaaa44581
Bug-Url: https://bugzilla.redhat.com/1358383
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java
2 files changed, 12 insertions(+), 17 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Roy Golan: Verified
  Liron Aravot: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/64425
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I427aa4e9ada86c59e4d7cf999dbdb23aaaa44581
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list