Change in ovirt-engine[master]: webadmin: Fix vNIC profile page for ja_JP locale

Code Review gerrit at ovirt.org
Fri Nov 25 12:40:07 UTC 2016


>From Tomas Jelinek <tjelinek at redhat.com>:

Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: Fix vNIC profile page for ja_JP locale
......................................................................


webadmin: Fix vNIC profile page for ja_JP locale

Because the Japanese word for the checkbox label "public" consumes more
horizontal space than then the English word, the VnicProfileWidget
looked distorted a bit as the help button appears on a different line
below other items on the page.

Since the available horizontal space was allocated already, the margin
of the label is squeezed, to avoid a second row for the
VnicProfileWidget.

Change-Id: I2b423d1d8353d7f72f119f22763a1034d324ab1e
Bug-Url: https://bugzilla.redhat.com/1255257
Signed-off-by: Dominik Holler <dholler at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.ui.xml
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Dominik Holler: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/67178
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b423d1d8353d7f72f119f22763a1034d324ab1e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list