Change in ovirt-engine[ovirt-engine-4.0.6]: imagetransfer: Expand permission checks for transfers.

Code Review gerrit at ovirt.org
Tue Nov 29 13:10:25 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: imagetransfer: Expand permission checks for transfers.
......................................................................


imagetransfer: Expand permission checks for transfers.

Currently, a permission check is being made only on the related storage domain.
This patch adds a permission check for the specific disk, in case it was
provided.

Change-Id: Ibf28a9887dc2c01810490fd1b81f45930094a7fb
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommandTest.java
2 files changed, 29 insertions(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Amit Aviram: Verified



-- 
To view, visit https://gerrit.ovirt.org/67451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf28a9887dc2c01810490fd1b81f45930094a7fb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.6
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list