Change in ovirt-engine[master]: core: Don't run checkstyle on modules/dependencies

Code Review gerrit at ovirt.org
Tue Nov 1 21:56:16 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Don't run checkstyle on modules/dependencies
......................................................................


core: Don't run checkstyle on modules/dependencies

A recent patch changed the checstyle configuration so that it runs in
all the sub-projectes inside the 'backend' directory. This means that it
also runs for the 'backend/modules/dependecies' sub-project. But this
sub-project doesn't contain source code, so running checkstyle doesn't
help, and it actually prevents some usages of this sub-project. For
example, we currently do the following from some CI jobs in order to
analyze the dependencies of the project:

  $ mvn clean package --projects \
  backend/manager/dependencies,\
  backend/manager/dependencies/common,\
  backend/manager/dependencies/tools \
  -DskipTests

Now this fails becaus it can't find the artifact that contains our
custom checstyle rules. To avoid this failure this patch moves the
configuration of the checstyle plugin to the sub-directories of the
'backend' directory that do contain source code, where running checstyle
is useful.

Change-Id: I3630e380b742d100801cb5a1c176ef8a52f3a46b
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/extensions-tool/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
4 files changed, 19 insertions(+), 8 deletions(-)

Approvals:
  Juan Hernandez: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/65950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3630e380b742d100801cb5a1c176ef8a52f3a46b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list