Change in ovirt-engine[master]: core: Test VdcActionType constant existence

Code Review gerrit at ovirt.org
Thu Nov 3 17:14:43 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Test VdcActionType constant existence
......................................................................


core: Test VdcActionType constant existence

VdcActionTypeTest has a test to ensure that any VdcActionType constant
has a corresponding command class.

This patch adds the reverse test, scanning the relevant packages using
org.reflections.Reflections and verifying that each command class has a
corresponding constant in VdcActionType.

Change-Id: I4acd826081cf0ec31e1a186f7089d97fabdfaea6
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandEnumTestUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VdcActionTypeTest.java
3 files changed, 42 insertions(+), 0 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/66046
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4acd826081cf0ec31e1a186f7089d97fabdfaea6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list