Change in ovirt-engine[master]: core: static CommandsFactory#getCommandPackages

Code Review gerrit at ovirt.org
Thu Nov 3 17:14:43 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: static CommandsFactory#getCommandPackages
......................................................................


core: static CommandsFactory#getCommandPackages

There's no reason for this access method to be an instance method. This
patch converts it to be static to match the rest of the class.

Change-Id: I03c902e3bbc3e26e772a0510460f20bf13f07303
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandsFactoryTest.java
2 files changed, 2 insertions(+), 10 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/66045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03c902e3bbc3e26e772a0510460f20bf13f07303
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list