Change in ovirt-engine-sdk-java[sdk_4.0]: Use BigInteger in examples

Code Review gerrit at ovirt.org
Fri Nov 4 11:36:14 UTC 2016


>From Ondra Machacek <omachace at redhat.com>:

Ondra Machacek has submitted this change and it was merged.

Change subject: Use BigInteger in examples
......................................................................


Use BigInteger in examples

The primary represenation of integers used by the SDK is the
'BigInteger' class. This patch change the examples to use them directly
when doing arithmethic, as that is more robust and the recommended
practice for users of the SDK.

Change-Id: I50854a24722324117110bb1398f27a032df47713
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit fc29db3472ace30d72489a0f3f6b717ef99fda2c)
---
M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddFloatingDisk.java
M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddVmDisk.java
2 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/66076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50854a24722324117110bb1398f27a032df47713
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list