Change in ovirt-engine-sdk[sdk_4.0]: Use COPYPOSTFIELDS for HTTP POST data

Code Review gerrit at ovirt.org
Tue Nov 8 13:21:38 UTC 2016


>From Ondra Machacek <omachace at redhat.com>:

Ondra Machacek has submitted this change and it was merged.

Change subject: Use COPYPOSTFIELDS for HTTP POST data
......................................................................


Use COPYPOSTFIELDS for HTTP POST data

Using POSTFIELDS instead of COPYPOSTFIELDS causes issue when,
passing data to setopt as function call instead of variable.

The explanation of COPYPOSTFIELDS from pycurl website:

 COPYPOSTFIELDS behaves as the POSTFIELDS option, but the
 original data is instead copied by the library, allowing
 the application to overwrite the original data after
 setting this option.

Change-Id: If9c80abcd331adfbc5fa11f29259d9d44053596e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1392878
Signed-off-by: Ondra Machacek <omachace at redhat.com>
---
M sdk/lib/ovirtsdk4/__init__.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/66255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9c80abcd331adfbc5fa11f29259d9d44053596e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list