Change in ovirt-engine[master]: core: GetManagementNetworkCandidatesQuery accessors

Code Review gerrit at ovirt.org
Wed Nov 9 08:14:25 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: GetManagementNetworkCandidatesQuery accessors
......................................................................


core: GetManagementNetworkCandidatesQuery accessors

With the test standardized in the previous patch, there's no need for
public access methods of internal resources that the test can override.
This patch cleans up the query's code by removing them.

Change-Id: Icbca4468dd4fe90b1b35ed8344331e67aab2ca9e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQuery.java
1 file changed, 2 insertions(+), 10 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/66289
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icbca4468dd4fe90b1b35ed8344331e67aab2ca9e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list