Change in ovirt-engine[master]: webadmin: Fix custom bond mode option input

Code Review gerrit at ovirt.org
Wed Nov 9 12:17:54 UTC 2016


>From Greg Sheremeta <gshereme at redhat.com>:

Greg Sheremeta has submitted this change and it was merged.

Change subject: webadmin: Fix custom bond mode option input
......................................................................


webadmin: Fix custom bond mode option input

The label and the input for "Custom Mode" options in the
SetupNetworksBondPopupView was only visible, if the bonding
mode is chosen to 'Custom'. In the previous implementation the higher
level container in the user interface did not provide enough space to
receive user inputs for "Custom Mode" options. Without choosing the
"Custom Mode", the user was not aware of the input of "Custom Mode"
options.

The higher level container in the user interface is increased and
they layout is changed to a Container of bootstrap grid system.
Additionally the "Custom Mode" options input is disabled, if the user
does not choose the "Custom Mode".

Change-Id: I4b7a4d251cdb50d5fa32fccb50910c9decc730d9
Bug-Url: https://bugzilla.redhat.com/1391130
Signed-off-by: Dominik Holler <dholler at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.ui.xml
2 files changed, 16 insertions(+), 16 deletions(-)

Approvals:
  Dominik Holler: Verified
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/66242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b7a4d251cdb50d5fa32fccb50910c9decc730d9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list