Change in ovirt-engine[master]: core: GetLunsByVgIdQueryTest: test executeQueryCommand()

Code Review gerrit at ovirt.org
Sun Nov 13 06:06:59 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: GetLunsByVgIdQueryTest: test executeQueryCommand()
......................................................................


core: GetLunsByVgIdQueryTest: test executeQueryCommand()

A query's test should test the query's logic by calling
executeQueryCommand(), not the QueriesCommandBase infrastructure of
executeCommand().

This patch rectifies the mistake made in GetLunsByVgIdQueryTest.

Change-Id: I9c465de2a118c270acdab7418ff5bc873676e48b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/lun/GetLunsByVgIdQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/lun/GetLunsByVgIdQueryTest.java
2 files changed, 1 insertion(+), 8 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/66528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c465de2a118c270acdab7418ff5bc873676e48b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list