Change in ovirt-engine[master]: core: GetLunsByVgIdQuery#getLunsForVgId param

Code Review gerrit at ovirt.org
Sun Nov 13 06:07:00 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: GetLunsByVgIdQuery#getLunsForVgId param
......................................................................


core: GetLunsByVgIdQuery#getLunsForVgId param

Use the vgId passed to the method instead of just assuming getVgId().
This has no functional benefit, as CURRENTLY the only place that uses
this method passes getVgId(), but it is more correct, and will prevent
hard-to-find bugs in the future.

Change-Id: I52a331e8582e6a40a354b0b40a62ba120fec314e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/lun/GetLunsByVgIdQuery.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/66527
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I52a331e8582e6a40a354b0b40a62ba120fec314e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list