Change in ovirt-engine[master]: core: remove incorrect logic in vm-analyzer

Code Review gerrit at ovirt.org
Sun Nov 20 12:28:46 UTC 2016


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: remove incorrect logic in vm-analyzer
......................................................................


core: remove incorrect logic in vm-analyzer

When we detect a VM that is running on a host that we did not
expect the VM to run on, we first examine the migration
statuses MigratingFrom and MigratingTo. Then, we used to have
the following logic: "if the VM is set as running on a
different host and it is not up on this host then it is being
migrated". This logic is obviously wrong - except for Down
state that is handled before, all other statuses should be
treated as the Up status.

Change-Id: Ib9cccca87b251810c6260ca14807e4c2d66d5b16
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Arik Hadas: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/66768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9cccca87b251810c6260ca14807e4c2d66d5b16
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list