Change in ovirt-engine[master]: core: CommandsWeightsUtilsTest redundant assert

Code Review gerrit at ovirt.org
Mon Nov 21 23:09:23 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: CommandsWeightsUtilsTest redundant assert
......................................................................


core: CommandsWeightsUtilsTest redundant assert

The weightsUtils instance is initialized by JUnit's framework. Asserting
that it's not null in essence checks that JUnit works as advertised,
which is redundant.

This patch removes this assert.

Change-Id: I1e620f83ec82b6b45c56e4b0f6331d48956478df
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/CommandsWeightsUtilsTest.java
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Liron Aravot: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/67147
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e620f83ec82b6b45c56e4b0f6331d48956478df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list