Change in gerrit-admin[master]: Add default-hooks directories

Code Review gerrit at ovirt.org
Tue Nov 29 09:11:52 UTC 2016


>From Shlomo Ben David <sbendavi at redhat.com>:

Shlomo Ben David has submitted this change and it was merged.

Change subject: Add default-hooks directories
......................................................................


Add default-hooks directories

In the current configuration every project has a 'hook' directory
with links to the custom_hooks directory.
- It is hard to maintain the hooks in this way
- The hooks order isn't correct (not running in the right order)

Now we will have:
- One structured directory (default-hooks) that is separated to the
  following directories:
  + check (hooks that checks patches vs bugs in bugzilla)
  + update (hooks that update [modify] bugs in bugzilla)
  + all (holds both check and update hooks)
- The hooks are running in the correct order
- All the hooks are labeled (i.e [hook-type].[bz].[number].[hook-name])
- If we want to set hooks for a specific project
  we just need to create a symbolic link inside the project directory
  to point to one of the directories (check,update,all)
  in the default-hooks directory.

Change-Id: Ic1afdbf4d6a103e0c6d3c42053fe6880e4fc7ed1
Fixes: OVIRT-760
Signed-off-by: Shlomi Ben-David <sbendavi at redhat.com>
---
A hooks/default-hooks/all/change-abandoned.bz.99.update_tracker
A hooks/default-hooks/all/change-merged.bz.98.set_modified
A hooks/default-hooks/all/change-merged.bz.99.update_tracker
A hooks/default-hooks/all/patchset-created.bz.1.check_bug_url
A hooks/default-hooks/all/patchset-created.bz.2.check_product
A hooks/default-hooks/all/patchset-created.bz.3.check_target_milestone
A hooks/default-hooks/all/patchset-created.bz.98.set_post
A hooks/default-hooks/all/patchset-created.bz.99.update_tracker
A hooks/default-hooks/check/patchset-created.bz.1.check_bug_url
A hooks/default-hooks/check/patchset-created.bz.2.check_product
A hooks/default-hooks/check/patchset-created.bz.3.check_target_milestone
A hooks/default-hooks/update/change-abandoned.bz.99.update_tracker
A hooks/default-hooks/update/change-merged.bz.98.set_modified
A hooks/default-hooks/update/change-merged.bz.99.update_tracker
A hooks/default-hooks/update/patchset-created.bz.98.set_post
A hooks/default-hooks/update/patchset-created.bz.99.update_tracker
16 files changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Shlomo Ben David: Verified
  Eyal Edri: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/66661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1afdbf4d6a103e0c6d3c42053fe6880e4fc7ed1
Gerrit-PatchSet: 3
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>



More information about the Engine-commits mailing list