Change in ovirt-engine[master]: core: AddDiskCommandTest @Spy annotation

amureini at redhat.com amureini at redhat.com
Wed Oct 5 10:27:05 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: AddDiskCommandTest @Spy annotation
......................................................................


core: AddDiskCommandTest @Spy annotation

Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy in order to set the ground for using injected mocks in
these tests in the future.

Change-Id: Ic9443fe686c9943a5cb0210b2054b3ea289c2ebd
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
1 file changed, 74 insertions(+), 104 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9443fe686c9943a5cb0210b2054b3ea289c2ebd
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list