Change in ovirt-engine[master]: webadmin: Fix Number format exception

awels at redhat.com awels at redhat.com
Fri Oct 7 12:44:31 UTC 2016


Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: Fix Number format exception
......................................................................


webadmin: Fix Number format exception

- In certain circumstances it is possible to get port=<not a number>
  into the options field of the fencing agent.
- Added validation that port must be a number in options before
  allowing the user to save the fence agent.

Change-Id: Icec06cea173b582e654eeb023e78eb5353970df0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1375646
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/KeyValuePairValidation.java
2 files changed, 33 insertions(+), 18 deletions(-)

Approvals:
  Alexander Wels: Verified
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/64938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icec06cea173b582e654eeb023e78eb5353970df0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list