Change in ovirt-engine[master]: core: cleanup in fullList flow

ahadas at redhat.com ahadas at redhat.com
Tue Oct 11 20:48:35 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: cleanup in fullList flow
......................................................................


core: cleanup in fullList flow

Rename IVdsServer#list(String, String[]) to fullList(String[]).
First, is better describes the operation that is done.
Second, the first argument is redundant as it is not used with
json-rpc and is always true with xml-rpc.

Change-Id: Ic09553d6149e17923824aad27a0dd3ddf70cf120
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FullListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
4 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/65331
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic09553d6149e17923824aad27a0dd3ddf70cf120
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list