Change in ovirt-engine[master]: core: ImportVmTemplateCommand#init

amureini at redhat.com amureini at redhat.com
Thu Oct 13 20:50:22 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: ImportVmTemplateCommand#init
......................................................................


core: ImportVmTemplateCommand#init

Move the complicated initializations (e.g., those that need a dao
call) to the init() method, where they belong.

Note that performing this change allows us to remove the redundant
stubbing in the test and rely on Mockito's mocking.

Change-Id: I436c47340566578956aed4cd3e84d0f327e2d9ac
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandTest.java
2 files changed, 6 insertions(+), 12 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I436c47340566578956aed4cd3e84d0f327e2d9ac
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list