Change in ovirt-engine[master]: core: RunVmCommandTest @Spy annotation

amureini at redhat.com amureini at redhat.com
Thu Oct 13 20:50:23 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: RunVmCommandTest @Spy annotation
......................................................................


core: RunVmCommandTest @Spy annotation

Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy. This change has two advantages - first, it's a tad more
elegant, as it saves the duplicate Mockito.spy calls. Second, and more
importantly, it sets the ground for using injected mocks in these tests
in the future.

Change-Id: Iae9ddd68a57ff72508160ae00a26599033dbcca8
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
1 file changed, 5 insertions(+), 20 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Betak: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae9ddd68a57ff72508160ae00a26599033dbcca8
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list