Change in ovirt-engine[master]: core: AddVmCommandTest use init()

amureini at redhat.com amureini at redhat.com
Thu Oct 13 20:50:24 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: AddVmCommandTest use init()
......................................................................


core: AddVmCommandTest use init()

Use init(), which is a "user-facing" method used to initialize the
"business" part of the command, instead of postConstruct() which is
geared to initialize CommandBase's internal structures which the test
does not, and should not, care about.

As a neat side-bonus, setting up the CommandContext could be dropped,
as the test really doesn't care about it.

Change-Id: I8002501d17a192a345c319c141763d7b976a62b0
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
1 file changed, 4 insertions(+), 9 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Betak: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64643
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8002501d17a192a345c319c141763d7b976a62b0
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list