Change in ovirt-engine[master]: build: Configure checkstyle for the backend

tnisan at redhat.com tnisan at redhat.com
Tue Oct 18 16:33:48 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: build: Configure checkstyle for the backend
......................................................................


build: Configure checkstyle for the backend

This patch configures  maven-checkstyle-plugin in backend/pom.xml.

Doing so has several advantages:

1. The plugin is configured once, and when authoring a new module
   under backend the author doesn't need to think whether or not to
   configure this plugin, and if so how.

2. A lot of repetitive boiler-plate configuration is saved.

3. Mistakes where checkstyle is not run (as happened, e.g., in the
   bll and utils modules) are avoided.

Change-Id: I4dcee5050c90c30fc4ddeec1a0e9110536e18ddb
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/extensions-tool/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
5 files changed, 8 insertions(+), 23 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/65481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4dcee5050c90c30fc4ddeec1a0e9110536e18ddb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list