Change in ovirt-engine[master]: core: MoveOrCopyDiskCommand#init

tnisan at redhat.com tnisan at redhat.com
Wed Oct 19 11:02:11 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: MoveOrCopyDiskCommand#init
......................................................................


core: MoveOrCopyDiskCommand#init

Override the init() method and move the logic from
defineVmTemplate() there, so we don't have to make any database calls
from the constructor.

This change allows us to clean up the test and remove [now] redundant
the MoveOrCopyDiskCommandDummy class.

Change-Id: I32fb4306af2d2e05292cf23614c991d3499627b8
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
2 files changed, 6 insertions(+), 20 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/64717
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I32fb4306af2d2e05292cf23614c991d3499627b8
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list