Change in ovirt-engine-sdk-java[master]: Convert 'all_content' parameter to 'All-Content' header

omachace at redhat.com omachace at redhat.com
Wed Oct 19 12:26:39 UTC 2016


Ondra Machacek has submitted this change and it was merged.

Change subject: Convert 'all_content' parameter to 'All-Content' header
......................................................................


Convert 'all_content' parameter to 'All-Content' header

Older versions of the engine (before 4.1) only accepted the
'all_content' parameter as an HTTP header. To better support those
versions of the engine this patch changes the SDK so that when the
'all_content' parameter is specified its value is copied to the
'All-Content' request header. So a request like this:

  GET /ovirt-engine/api/vms/123?all_content=true

Will be translated into this:

  GET /ovirt-engine/api/vms/123?all_content=true
  All-Content: true

Change-Id: I2b7be557957456cc834e2f22468bb8e8485e54f7
Signed-off-by: Ondra Machacek <omachace at redhat.com>
---
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpConnection.java
M sdk/src/test/java/org/ovirt/engine/sdk4/ServerTest.java
M sdk/src/test/java/org/ovirt/engine/sdk4/VmsServiceTest.java
3 files changed, 36 insertions(+), 1 deletion(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Juan Hernandez: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65597
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b7be557957456cc834e2f22468bb8e8485e54f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list