Change in ovirt-engine[master]: core: UpdateVmDiskCommandTest @Spy annotation

tnisan at redhat.com tnisan at redhat.com
Wed Oct 19 18:13:40 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: UpdateVmDiskCommandTest @Spy annotation
......................................................................


core: UpdateVmDiskCommandTest @Spy annotation

Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy in order to set the ground for using injected mocks in
these tests in the future.

Change-Id: I8ad4edf82f1d0c48c200540296ad27fc86c47aee
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
1 file changed, 67 insertions(+), 92 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved; Passed CI tests
  Allon Mureinik: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ad4edf82f1d0c48c200540296ad27fc86c47aee
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list