Change in ovirt-engine[master]: core: UpdateVmDiskCommandTest: use single

tnisan at redhat.com tnisan at redhat.com
Wed Oct 19 18:13:42 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: UpdateVmDiskCommandTest: use single
......................................................................


core: UpdateVmDiskCommandTest: use single

The entire test's structure set up List<VM> (see, e.g.,
initializeCommand). However, these lists always contained only a
single VM, which made very little sense.

This patch attempts to rationalize the test by changing the semantics to
use a single VM in all the method signatures.

Change-Id: I0976b1363ea009ba150c05c1fb5714b010fbe174
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
1 file changed, 22 insertions(+), 45 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved; Passed CI tests
  Allon Mureinik: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0976b1363ea009ba150c05c1fb5714b010fbe174
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list