Change in ovirt-engine[master]: core: RemoveQuotaCommandTest single command instance

tnisan at redhat.com tnisan at redhat.com
Thu Oct 20 09:02:47 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: RemoveQuotaCommandTest single command instance
......................................................................


core: RemoveQuotaCommandTest single command instance

Rework the test to use a single command instance, annotated with @Spy
and @InjectMocks in order to reduce code duplication and allow easier
injections.

Instead of using different Quota objects, the test setup initializes a
single Quota data member which specific tests can continue and
specialize (e.g., by setting it to be the default quota).

Change-Id: I97a048f6d4749c915a735cb904a08c15f78347b3
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java
1 file changed, 18 insertions(+), 24 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/64775
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97a048f6d4749c915a735cb904a08c15f78347b3
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list