Change in ovirt-engine[master]: core: UpdateRngDeviceTest spying

tnisan at redhat.com tnisan at redhat.com
Thu Oct 20 12:37:59 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: UpdateRngDeviceTest spying
......................................................................


core: UpdateRngDeviceTest spying

Spy the command instead of stubbing it as per the project's standard.
Although this approach is semantically similar, it saves a lot of code
bloating and sets up the ability to inject mocked DAOs in the following
patches.

Change-Id: I02fe3da9160f9e6ff11ed218a32a9d39489623b5
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateRngDeviceTest.java
1 file changed, 6 insertions(+), 21 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jakub Niedermertl: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/64784
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I02fe3da9160f9e6ff11ed218a32a9d39489623b5
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list