Change in ovirt-engine[master]: webadmin: Fix coverity issue in VmModelBehaviorBase

tnisan at redhat.com tnisan at redhat.com
Thu Oct 20 12:54:20 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Fix coverity issue in VmModelBehaviorBase
......................................................................


webadmin: Fix coverity issue in VmModelBehaviorBase

This fixes Coverity issue 1353386 (logical dead code in
VmModelBehaviorBase:901)

Change I4706419295d67f7a022a85bc61f75bb46def2b6b made CPU pinning always
available for local data centers yet failed to remove the remaining logic
this patch removes it.

Change-Id: Ic4e8d7b87367354b6202d70e98c7ab0663ad1b46
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
3 files changed, 1 insertion(+), 8 deletions(-)

Approvals:
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Martin Betak: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/65137
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4e8d7b87367354b6202d70e98c7ab0663ad1b46
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list