Change in ovirt-engine[master]: core: Make LiveStorageMigrationHelper a @Singleton

tnisan at redhat.com tnisan at redhat.com
Mon Oct 24 20:09:31 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Make LiveStorageMigrationHelper a @Singleton
......................................................................


core: Make LiveStorageMigrationHelper a @Singleton

Annotate the class as a @Singleton, @Inject it where its needed and
@Inject the DAOs it needs to it instead of relying on them having
public access from the command passed to it.

Change-Id: I9d608a01351020f210af074be3c0255512f8f36e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveStorageMigrationHelper.java
2 files changed, 22 insertions(+), 7 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved; Passed CI tests
  Allon Mureinik: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64801
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d608a01351020f210af074be3c0255512f8f36e
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list