Change in ovirt-engine[master]: core: ManageGlusterServiceCommand: inline members

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: ManageGlusterServiceCommand: inline members
......................................................................


core: ManageGlusterServiceCommand: inline members

Keeping members in the command that are just duplicates of the values
form the parameters objects leads to data duplicity and potentially
nasty bugs.
This patch clears up the duplicity by using the values directly from the
parameters. As a side bonus, this also makes the code cleaner and
testing much easier.

Change-Id: Ice26853743c914aa7bd448568fc5d808d8fa291f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java
1 file changed, 16 insertions(+), 32 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved; Passed CI tests
  Allon Mureinik: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65195
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ice26853743c914aa7bd448568fc5d808d8fa291f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>