Change in ovirt-engine[master]: core: DeleteAllGlusterVolumeSnapshotsCommand#init

tnisan at redhat.com tnisan at redhat.com
Mon Oct 24 22:32:34 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: DeleteAllGlusterVolumeSnapshotsCommand#init
......................................................................


core: DeleteAllGlusterVolumeSnapshotsCommand#init

Move the initialization logic from the constructor to the init method,
as per the project's standard.

The init() method is called as part of the command construction
framework, and since it's done in the postConstruct phase, it's safe to
use DAO calls there, allowing the test to be cleaned up in the following
patch.

Change-Id: I34f1e7c273ae509aad2e670dde38dfe7a666c712
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteAllGlusterVolumeSnapshotsCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved; Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/64809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34f1e7c273ae509aad2e670dde38dfe7a666c712
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list