Change in ovirt-engine[master]: webadmin, userportal: Fix JqueryUtils.getTextFromHtml

awels at redhat.com awels at redhat.com
Tue Oct 25 12:17:12 UTC 2016


Alexander Wels has submitted this change and it was merged.

Change subject: webadmin,userportal: Fix JqueryUtils.getTextFromHtml
......................................................................


webadmin,userportal: Fix JqueryUtils.getTextFromHtml

oVirt GWT UI currently uses jQuery version 1.11.3

Quote from jQuery upgrade guide [1]:

"
As of 1.9, a string is only considered to be HTML if it starts
with a less-than ("<") character.
..
If a string is known to be HTML but may start with arbitrary text
that is not an HTML tag, pass it to jQuery.parseHTML() which will
return an array of DOM nodes representing the markup.
"

[1] http://stage.jquery.com/upgrade-guide/1.9/#jquery-htmlstring-versus-jquery-selectorstring

The problem was that jQuery treated `html` argument as selector
if the string didn't start with `<` character. Because of this,
the string failed to parse as selector, resulting in error like:

  Syntax error, unrecognized expression: Dev. Size

This patch fixes the problem.

Change-Id: Ic939c09f3cb2e2a80b6ef2dd15cb759cbc27f946
Bug-Url: https://bugzilla.redhat.com/1386765
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/JqueryUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/65690
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic939c09f3cb2e2a80b6ef2dd15cb759cbc27f946
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list