Change in ovirt-engine[master]: core: SchedulingManager#schedule

amureini at redhat.com amureini at redhat.com
Thu Oct 27 12:05:53 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: SchedulingManager#schedule
......................................................................


core: SchedulingManager#schedule

The @NotNull constraint introduced on this by 0e4ae6 method caused
RunVmCommand to fail with the following error:

2016-10-27 05:31:41,519 ERROR [org.ovirt.engine.core.bll.RunVmOnceCommand] (default task-19) [7b964e35] Exception: javax.validation.UnexpectedTypeException: HV000186: The constraint of type 'javax.validation.constraints.NotNull' defined on 'schedule.<return value>' has multiple matching constraint validators which is due to an additional value handler of type 'org.hibernate.validator.internal.engine.valuehandling.OptionalValueUnwrapper'. It is unclear which value needs validating. Clarify configuration via @UnwrapValidatedValue.

This patch removes the problematic annotation and fixes the issue.

Change-Id: I60fa11fe9e3805e293334dabc6cff156833e0310
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/65784
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I60fa11fe9e3805e293334dabc6cff156833e0310
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list