Change in ovirt-engine[master]: core: Remove DBConfigUtils(boolean) constructor

amureini at redhat.com amureini at redhat.com
Thu Oct 27 22:46:09 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove DBConfigUtils(boolean) constructor
......................................................................


core: Remove DBConfigUtils(boolean) constructor

The DBConfigUtils(boolean) constructor was only used in
DBConfigUtilsTest, which just passes true, giving it the same behavior
as calling the default constructor.

This patch removes the redundant constructor in order to clean up the
code and make it easier to read.

Change-Id: I7b02ad3fb337712644511d1c4b41ee829783d5bf
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtilsTest.java
2 files changed, 3 insertions(+), 15 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65020
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b02ad3fb337712644511d1c4b41ee829783d5bf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list