Change in ovirt-engine[master]: core: DBConfigUtilsTest's DBConfigUtils ctor usage

amureini at redhat.com amureini at redhat.com
Thu Oct 27 22:46:09 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: DBConfigUtilsTest's DBConfigUtils ctor usage
......................................................................


core: DBConfigUtilsTest's DBConfigUtils ctor usage

The test currently calls new DBConfigUtils(false), immediately
followed by config.refreshVdcOptionCache(dbfacade), which is exactly
the same as just calling new DBConfigUtils(true).

This patch streamlines the code as to not duplicate code between a test
and the class that it tests.

Change-Id: I4117ff736380b84cb86cae8c8baae8dd298a89f2
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtilsTest.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65018
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4117ff736380b84cb86cae8c8baae8dd298a89f2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list