Change in ovirt-engine[master]: core: Remove redundant test in UpdateVmCommandTest

tnisan at redhat.com tnisan at redhat.com
Sun Oct 30 16:18:43 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Remove redundant test in UpdateVmCommandTest
......................................................................


core: Remove redundant test in UpdateVmCommandTest

testMigratoinCanBeSetWhenVMUsesScsiReservation is supposed to test if a VM
can be migrated with regrards to whether SCSI reservation is set, however,
nothing in UpdateVmCommand test or ever refers in any way to the scsi
reservation value thus making this test redundant

Change-Id: Ib638643246025eefbbd5d1aef50e435a75f3572a
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
1 file changed, 0 insertions(+), 14 deletions(-)

Approvals:
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/65766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib638643246025eefbbd5d1aef50e435a75f3572a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list