Change in ovirt-engine[master]: upload: Support supplied image for an image transfer.

amureini at redhat.com amureini at redhat.com
Mon Oct 31 10:34:07 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: upload: Support supplied image for an image transfer.
......................................................................


upload: Support supplied image for an image transfer.

For REST API support, we want to be able to execute the upload
command with a supplied image. Currently when executing the command,
the image is created. This patch will create the image only if no
image was supplied, otherwise, set needed parameters for the command
according to the supplied image.

Add tests for the upload command, verifying this change.

Change-Id: I41066d1b8d2d7b18e4ceb12e1754b99189b3b258
Bug-Url: https://bugzilla.redhat.com/1337077
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UploadImageParameters.java
5 files changed, 383 insertions(+), 22 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41066d1b8d2d7b18e4ceb12e1754b99189b3b258
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list