Change in ovirt-engine[master]: frontend: fix custom compatibility version field setting

tjelinek at redhat.com tjelinek at redhat.com
Mon Oct 31 13:22:31 UTC 2016


Tomas Jelinek has submitted this change and it was merged.

Change subject: frontend: fix custom compatibility version field setting
......................................................................


frontend: fix custom compatibility version field setting

Fix the UI behaviour of both webadmin and userportal for setting the
VM->System tab->Custom compatibility version (CCV) drop down menu to
avoid refreshing and reseting the value after manually changing it by
the user.

Changing the CCV field value for a VM/pool/template (choosing a
different value from pool down menu), causes few VM fields
values to be reseted and refreshed back to template defaults.
this fix avoid from the CCV field itself to be reseted as well.

This change influence the template field and CCV field behaviour for the
following use cases:
New VM
New VM from Template
New pool
Edit pool

Change-Id: I4e20cdb868740241338d007686adf9f8d780bb61
Bug-Url: https://bugzilla.redhat.com/1367405
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmFromTemplateModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
8 files changed, 65 insertions(+), 15 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sharon Gratch: Verified



-- 
To view, visit https://gerrit.ovirt.org/65809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e20cdb868740241338d007686adf9f8d780bb61
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list