Change in ovirt-engine[ovirt-engine-4.0]: restapi: Don't add V3 guest IP to links

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Sep 2 18:39:42 UTC 2016


Piotr Kliczewski has submitted this change and it was merged.

Change subject: restapi: Don't add V3 guest IP to links
......................................................................


restapi: Don't add V3 guest IP to links

Currently the V3 compatibility layer tries to add the guest IP to all
the returned objects of type "vm". That is wrong, as links, for example,
shouldn't include such information. To solve the problem this patch
changes the API so that the population of the guest IP is performed only
for objects of type "vm" returned by the "list", "get", and "update"
operations of the services that manage virtual machines.

Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda
Bug-Url: https://bugzilla.redhat.com/1368552
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 371894f4b19605ebe10fe0e5e2cddd0146482c4a)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java
4 files changed, 71 insertions(+), 57 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list