Change in ovirt-engine[ovirt-engine-4.0.4]: restapi: Don't add V3 disk attachment details to links

tnisan at redhat.com tnisan at redhat.com
Mon Sep 5 16:26:04 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: restapi: Don't add V3 disk attachment details to links
......................................................................


restapi: Don't add V3 disk attachment details to links

Currently the V3 compatibility layer tries to add the attachment details
(bootable, etc) to all the returned objects of type "disk". That is
wrong, as links, for example, shoundn't include such information. To
solve the problem this patch changes the API so that the population of
these details is performed only for objects of type "disk" returned by
the "list", "get", and "update" operations of the services that manage
virtual machine disks.

Change-Id: Ic8bc7e4b498d3d7ee7d09b60432b08f12be669c3
Bug-Url: https://bugzilla.redhat.com/1368552
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 9aa386f4ea54dd69e96fe87176a394ef6113d3ef)
(cherry picked from commit c555df2ad30c9659a362d27e670d4192837ac4a0)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java
4 files changed, 49 insertions(+), 79 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63323
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8bc7e4b498d3d7ee7d09b60432b08f12be669c3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.4
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list