Change in ovirt-engine[master]: backend: Refactor loading of Backend Services

rgolan at redhat.com rgolan at redhat.com
Tue Sep 6 08:20:10 UTC 2016


Roy Golan has submitted this change and it was merged.

Change subject: backend: Refactor loading of Backend Services
......................................................................


backend: Refactor loading of Backend Services

Backend services (classes implementing the BackendService marker interface) were
loaded from 2 different places (Backend, InitServicesOnStartupBean) using CDI
instance lookup.

This duplicate logic was extracted into newly created ServiceLoader whose sole
purpose is to provide a simple and uniform mechanism for loading of services.

Change-Id: I5454be63f248f110f7ebf333e3876332f171da19
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ServiceLoader.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/BackendService.java
4 files changed, 48 insertions(+), 14 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Martin Betak: Verified
  Roy Golan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/62288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5454be63f248f110f7ebf333e3876332f171da19
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list