Change in ovirt-engine[master]: core: rename QuotaManagerTest#testSetup to setUp

amureini at redhat.com amureini at redhat.com
Sun Sep 11 20:49:43 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: rename QuotaManagerTest#testSetup to setUp
......................................................................


core: rename QuotaManagerTest#testSetup to setUp

The method testSetup() looks like an old JUnit 3 style test although
it's actually a setup method annotated with @Before.

This patch renames the method to remove some potential confusion.

Change-Id: I8dd0278b15ac04f97103250d19436d88e1bb053a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Roy Golan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/63571
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8dd0278b15ac04f97103250d19436d88e1bb053a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list