Change in ovirt-engine[master]: tests: remove assertFailsWithValidateMessage occurrences.

amureini at redhat.com amureini at redhat.com
Mon Sep 12 09:18:13 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: tests: remove assertFailsWithValidateMessage occurrences.
......................................................................


tests: remove assertFailsWithValidateMessage occurrences.

assertFailsWithValidateMessage is currently duplicated in two
test classes, while ValidateTestUtils already supplies its
functionallity in runAndAssertValidateFailure(..).

Replace assertFailsWithValidateMessage with runAndAssertValidateFailure.

Change-Id: I0203ddfeef989674af8152b2725a83266183e29b
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeOvirtNodeInternalCommandTest.java
2 files changed, 7 insertions(+), 19 deletions(-)

Approvals:
  Amit Aviram: Verified
  Allon Mureinik: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0203ddfeef989674af8152b2725a83266183e29b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list