Change in ovirt-engine-sdk[master]: Fix generating of singular and plural tag names

omachace at redhat.com omachace at redhat.com
Tue Sep 13 12:18:42 UTC 2016


Ondra Machacek has submitted this change and it was merged.

Change subject: Fix generating of singular and plural tag names
......................................................................


Fix generating of singular and plural tag names

Previously we generated as tag name the name of the Python type,
which is incorrect and it should be schema name. This patch fixes it.

In addition it adds example of adding openstack image provider.

Change-Id: I1c27f780d9fe09394e643f33ed3e495bb811df8a
Signed-off-by: Ondra Machacek <omachace at redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java
A sdk/examples/add_openstack_image_provider.py
M sdk/tests/test_reader.py
3 files changed, 94 insertions(+), 4 deletions(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Juan Hernandez: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63732
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c27f780d9fe09394e643f33ed3e495bb811df8a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list