Change in ovirt-engine[master]: backend: Remove usage of extraneous lock objects

mbetak at redhat.com mbetak at redhat.com
Thu Sep 15 10:18:57 UTC 2016


Martin Betak has submitted this change and it was merged.

Change subject: backend: Remove usage of extraneous lock objects
......................................................................


backend: Remove usage of extraneous lock objects

When assuring mutual exclusion on instance or class level, extra monitor
objects are unnecessary and can be replaced with standard java usage of:

  synchronized (this) { ... }

or

  synchronized (MyClass.class) { ... }

Replaced all such occurrences.

Change-Id: I8dcb82ac09f494e731b86813b10b8772659e389b
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsIdVDSCommandBase.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
3 files changed, 6 insertions(+), 12 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Martin Betak: Verified
  Arik Hadas: Looks good to me, approved
  Liron Aravot: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63154
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8dcb82ac09f494e731b86813b10b8772659e389b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list