Change in ovirt-engine[master]: engine: Remove UncommentedMain checkstyle

amureini at redhat.com amureini at redhat.com
Thu Sep 15 18:56:26 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: engine: Remove UncommentedMain checkstyle
......................................................................


engine: Remove UncommentedMain checkstyle

This checkstyle rule is violated by virtually all the main methods we
have.
Instead of having it and suppressing it for all its occurances, it
makes more sense to simply drop it.

Change-Id: I4123e09bf17853745edc1269839af1dcb31acca0
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/pom.xml
M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml
M build-tools-root/checkstyles/src/main/resources/checkstyle.xml
3 files changed, 0 insertions(+), 16 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63944
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4123e09bf17853745edc1269839af1dcb31acca0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list