Change in ovirt-engine-sdk-ruby[master]: Empty list is not written to XML

juan.hernandez at redhat.com juan.hernandez at redhat.com
Thu Sep 22 15:40:43 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: Empty list is not written to XML
......................................................................


Empty list is not written to XML

When the user wants to send an empty list to the server, it is not
currently possible. For example when the user wants to create non VM
network he has to send an empty usages element. But if he sets the
"Network.usages" attribute to empty list, the empty usages element isn't
sent.

This patch fixes that.

Change-Id: Iab4f0af3701b4b812800adc7cc527c4506b1a4ea
Signed-off-by: Ondra Machacek <omachace at redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java
A sdk/spec/network_writer_spec.rb
2 files changed, 84 insertions(+), 1 deletion(-)

Approvals:
  Ondra Machacek: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64314
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab4f0af3701b4b812800adc7cc527c4506b1a4ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list