Change in ovirt-engine[master]: webadmin, userportal: Improve UiCommonEditorDriver cleanup() ...

awels at redhat.com awels at redhat.com
Wed Sep 28 13:30:19 UTC 2016


Alexander Wels has submitted this change and it was merged.

Change subject: webadmin,userportal: Improve UiCommonEditorDriver cleanup() impl.
......................................................................


webadmin,userportal: Improve UiCommonEditorDriver cleanup() impl.

Make sure that each call like

  getEditor().myField.cleanup();

is wrapped in

  if (getEditor().myField != null)

block to avoid potential NPEs.

Change-Id: I57f433ee4fbe2f89e1d1d083c84d01655b570a5e
Bug-Url: https://bugzilla.redhat.com/1368101
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java
1 file changed, 10 insertions(+), 2 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/64535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I57f433ee4fbe2f89e1d1d083c84d01655b570a5e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list