Change in ovirt-engine[master]: core: CreateGlusterVolumeCommand.getVolume()

amureini at redhat.com amureini at redhat.com
Thu Sep 29 12:40:00 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: CreateGlusterVolumeCommand.getVolume()
......................................................................


core: CreateGlusterVolumeCommand.getVolume()

Add a utility method getVolume() to return the volume from the
parameters instead of saving it as a data member.

This achieves two things:
First, from a design perspective, it saves the need to keep the same
object in two places.
Second, it allows for more flexibility, and lends ease to testing the
class in the following patches of the series.

Change-Id: If8c30fc9ea0822e3832b132ef3f13070a9f7f4f8
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java
1 file changed, 23 insertions(+), 23 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Yevgeny Zaspitsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/64610
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If8c30fc9ea0822e3832b132ef3f13070a9f7f4f8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list